Skip to content

feat(ui): add keytrace-style identity visualizer (poc)#2616

Open
BittuBarnwal7479 wants to merge 30 commits into
npmx-dev:mainfrom
BittuBarnwal7479:feat/adopt-keytrace
Open

feat(ui): add keytrace-style identity visualizer (poc)#2616
BittuBarnwal7479 wants to merge 30 commits into
npmx-dev:mainfrom
BittuBarnwal7479:feat/adopt-keytrace

Conversation

@BittuBarnwal7479
Copy link
Copy Markdown
Contributor

@BittuBarnwal7479 BittuBarnwal7479 commented Apr 23, 2026

🔗 Linked issue

resolves #2583


🧭 Context

This PR started as a UI POC. It is now updated to integrate real Keytrace claim data on /profile/{domain}.


📚 Description

What changed?

  • Integrated real Keytrace claim fetching via @keytrace/claims
  • Profile header now renders real identity data (name/avatar; banner support in UI)
  • Linked accounts now come from real claims (not synthetic account generation)
  • Reverify flow is wired end-to-end to real claims
  • Added safer proofMethod mapping with validation (no unsafe cast)
  • Fallback behavior is now explicit:
    • real data when available
    • no-claims state when user has no claims
    • service-unavailable state when Keytrace cannot be reached
    • removed misleading mock profile fallback

Verification

  • Tested real handle lookup (example: zeu.dev) returns verified claims
  • Confirmed profile page renders linked accounts from live Keytrace data
  • Confirmed no-claims and unavailable states show empty/non-misleading account output
  • Reverify updates status/last-checked using real claim matching

Notes

  • This PR remains read-only UI (no linking flow creation yet)
  • Account-link creation/verification authoring flow can be follow-up work

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jun 4, 2026 5:22pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jun 4, 2026 5:22pm
npmx-lunaria Ignored Ignored Jun 4, 2026 5:22pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Integrates Keytrace profile linking functionality into the application by adding Vue components for displaying linked accounts, API endpoints for fetching profile data and reverifying accounts, TypeScript types for type safety, internationalised UI text across 30+ locales, and server utilities for platform mapping and verification status determination.

Changes

Cohort / File(s) Summary
Vue Components for Keytrace UI
app/components/AccountItem.vue, app/components/LinkedAccounts.vue, app/components/ProfileHeader.vue
Three new components displaying profile headers with avatar/banner fallbacks, linked accounts lists with verification status legends, and individual account items with re-verify functionality including progress indicators and error handling.
Profile Data Composable
app/composables/useKeytraceProfile.ts
New composable fetching Keytrace profile and accounts data, providing sorted/filtered computed properties (verified, non-verified, sorted by status priority and platform name).
Keytrace API Endpoints
server/api/keytrace/[domain].ts, server/api/keytrace/reverify.post.ts
Two server endpoints: first fetches profile and linked accounts from Keytrace service with fallback handling; second reverifies a single account and returns updated status/timestamps/failure reasons.
Keytrace Types and Utilities
shared/types/keytrace.ts, server/utils/keytrace.ts
Type definitions for profiles, accounts, verification statuses, proof methods, and reverification requests/responses; utility functions for bidirectional platform-to-claimtype mapping, claim field extraction, staleness determination (30-day threshold), and verification status computation.
Profile Page Integration
app/pages/profile/[identity]/index.vue
Modified profile page to integrate Keytrace profile header and linked accounts sections using the new composable, restructured likes section with new error and empty state messaging.
Internationalisation Updates
i18n/locales/{ar,az,bg,bn,cs,de,en,es,fr,hi,hu,id,it,ja,kn,mr,nb,ne,nl,pl,pt,ru,sr,ta,te,tr,uk,vi,zh}*.json, i18n/schema.json
Added profile-scoped UI text keys across 30 locale files for public interests descriptions, likes error/empty states, linked accounts titles/summaries/status labels, and avatar labels; removed deprecated common.error key; updated schema to enforce new keys.
Accessibility and Dependencies
test/nuxt/a11y.spec.ts, package.json
Added accessibility audit coverage for ProfileHeader, LinkedAccounts, and AccountItem components; added @keytrace/claims (v1.4.0) runtime dependency.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Browser Client
    participant Page as Profile Page
    participant Composable as useKeytraceProfile
    participant API as /api/keytrace/[domain]
    participant Keytrace as Keytrace Service
    
    Client->>Page: Navigate to profile/[identity]
    Page->>Composable: useKeytraceProfile(identity)
    Composable->>API: useFetch(/api/keytrace/{domain})
    API->>Keytrace: getClaimsForHandle(domain)
    Keytrace-->>API: ClaimVerificationResult[]
    API->>API: Map claims to KeytraceProfile + accounts
    API-->>Composable: KeytraceResponse
    Composable->>Composable: Compute sorted/filtered accounts
    Composable-->>Page: profile, accounts, loading state
    Page->>Page: Render ProfileHeader + LinkedAccounts
Loading
sequenceDiagram
    participant User as User
    participant AccountItem as AccountItem Component
    participant API as /api/keytrace/reverify
    participant Keytrace as Keytrace Service
    
    User->>AccountItem: Click "Re-verify" button
    AccountItem->>AccountItem: Show tooltip panel
    AccountItem->>AccountItem: Start 4-step progress indicator
    AccountItem->>API: POST reverify request
    API->>Keytrace: getClaimsForHandle(identity)
    Keytrace-->>API: Updated ClaimVerificationResult
    API->>API: Map claim to reverification response
    API-->>AccountItem: KeytraceReverifyResponse
    AccountItem->>AccountItem: Update status/lastCheckedAt/failureReason
    AccountItem->>AccountItem: Complete progress, close tooltip
    Note over User,AccountItem: On error: show error message, adjust auto-close delay
Loading

Suggested reviewers

  • serhalp
  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: adding a keytrace-style identity visualizer UI component, which is the primary focus of this PR.
Description check ✅ Passed The description is directly related to the changeset, providing context about Keytrace integration, real claim data fetching, and the UI components added.
Linked Issues check ✅ Passed The PR fulfils the primary objectives from issue #2583: implements a Keytrace visualizer on profile pages displaying identity data and linked accounts from real Keytrace claims.
Out of Scope Changes check ✅ Passed All changes align with the stated objectives. The PR implements Keytrace visualisation and reverify flows (read-only), with account-linking creation properly deferred as future work.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ar-EG.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ar.json Localization changed, will be marked as complete. 🔄️
i18n/locales/az-AZ.json Localization changed, will be marked as complete. 🔄️
i18n/locales/bg-BG.json Localization changed, will be marked as complete. 🔄️
i18n/locales/bn-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/cs-CZ.json Localization changed, will be marked as complete. 🔄️
i18n/locales/de-AT.json Localization changed, will be marked as complete. 🔄️
i18n/locales/de-DE.json Localization changed, will be marked as complete. 🔄️
i18n/locales/de.json Localization changed, will be marked as complete. 🔄️
i18n/locales/en-GB.json Localization changed, will be marked as complete. 🔄️
i18n/locales/en.json Source changed, localizations will be marked as outdated.
i18n/locales/es-419.json Localization changed, will be marked as complete. 🔄️
i18n/locales/es.json Localization changed, will be marked as complete. 🔄️
i18n/locales/fr-FR.json Localization changed, will be marked as complete. 🔄️
i18n/locales/hi-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/hu-HU.json Localization changed, will be marked as complete. 🔄️
i18n/locales/id-ID.json Localization changed, will be marked as complete. 🔄️
i18n/locales/it-IT.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ja-JP.json Localization changed, will be marked as complete. 🔄️
i18n/locales/kn-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/mr-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/nb-NO.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ne-NP.json Localization changed, will be marked as complete. 🔄️
i18n/locales/nl.json Localization changed, will be marked as complete. 🔄️
i18n/locales/pl-PL.json Localization changed, will be marked as complete. 🔄️
i18n/locales/pt-BR.json Localization changed, will be marked as complete. 🔄️
i18n/locales/pt-PT.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ro-RO.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ru-RU.json Localization changed, will be marked as complete. 🔄️
i18n/locales/sr-Latn-RS.json Localization changed, will be marked as complete. 🔄️
i18n/locales/ta-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/te-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/tr-TR.json Localization changed, will be marked as complete. 🔄️
i18n/locales/uk-UA.json Localization changed, will be marked as complete. 🔄️
i18n/locales/vi-VN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/zh-CN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/zh-TW.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 10

🧹 Nitpick comments (4)
CONTRIBUTING.md (1)

351-351: Documentation update correctly reflects the routing change.

Swapping the unplugin-vue-router reference for Nuxt's experimental typedPages option is consistent with the dependency changes in package.json. Minor nit: typedPages is flagged as experimental in Nuxt — it may be worth a brief parenthetical note so contributors know the type-safety guarantee depends on that flag being enabled in nuxt.config.ts.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CONTRIBUTING.md` at line 351, Update the CONTRIBUTING.md note to mention that
Nuxt's typedPages option is experimental and that the type-safety guarantees for
using object-syntax named routes depend on enabling typedPages in
nuxt.config.ts; specifically, add a short parenthetical after the sentence that
recommends "object syntax with named routes" referencing the experimental nature
of the typedPages option and instructing contributors to enable typedPages in
nuxt.config.ts to get the typed route benefits.
.github/workflows/ci.yml (1)

117-118: Use $GITHUB_WORKSPACE instead of hard-coding the Actions workspace path.

Line 118 bakes in the current repository path. Using the runtime variable maintains compatibility if the repository name or checkout location changes.

Proposed change
       - name: 👑 Fix Git ownership
-        run: git config --global --add safe.directory /__w/npmx.dev/npmx.dev
+        run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 117 - 118, Replace the hard-coded path
in the "👑 Fix Git ownership" step by using the GitHub Actions runtime variable:
update the git config --global --add safe.directory command to use
$GITHUB_WORKSPACE instead of the literal "/__w/npmx.dev/npmx.dev" so the
safe.directory is set dynamically for the checked-out repo.
app/components/LinkedAccounts.vue (1)

4-9: Legend colours bypass the app's design tokens.

Other components in the app style via semantic tokens (bg-bg-subtle, text-fg-muted, border-border) so they respond to accent/background theme settings. The raw palette utilities here (bg-emerald-500/15, text-yellow-300, etc.) will look identical across themes and may clash on light backgrounds. Consider introducing status-specific semantic classes or at minimum verifying contrast on both light and dark themes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/components/LinkedAccounts.vue` around lines 4 - 9, The statusLegend array
uses raw Tailwind color utilities (statusLegend, className) which bypass the
app's semantic design tokens; replace these hardcoded palette classes with
semantic token-based classes (e.g., create status-specific utility classes like
.status-verified, .status-unverified, .status-stale, .status-failed that map to
tokens such as bg-bg-subtle / text-fg-muted / border-border or token variants
for each status) and update statusLegend.className to reference those semantic
classes so the badges respect theme/accent settings and verify contrast in both
light and dark themes.
app/composables/useKeytraceProfile.ts (1)

1-1: Rely on the project’s shared-type auto-imports here.

This composable is under app/composables, so the explicit #shared/types/keytrace import duplicates the repo’s Nuxt auto-import convention for shared/types/*.

♻️ Proposed cleanup
-import type { KeytraceAccount, KeytraceResponse } from '#shared/types/keytrace'
-

Based on learnings, “exports from shared/types/* … are auto-imported by Nuxt for composables and components. Do not add explicit import statements … in files under app/composables”.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/composables/useKeytraceProfile.ts` at line 1, The explicit import of
KeytraceAccount and KeytraceResponse at the top of useKeytraceProfile.ts
duplicates the repo's Nuxt auto-imports for shared/types in composables; remove
the line "import type { KeytraceAccount, KeytraceResponse } from
'#shared/types/keytrace'" and rely on the project-wide auto-imported types
(references to KeytraceAccount and KeytraceResponse inside the
useKeytraceProfile composable should continue to work without the explicit
import).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/components/AccountItem.vue`:
- Around line 202-206: getStepState currently treats a step as 'active' when
currentVerificationStep === stepIndex AND (isReverifying OR reverifyError),
which keeps the spinner running after a failure; update the condition in
getStepState (and the duplicate logic around the other block) to require
isReverifying to be true and reverifyError to be false (e.g., use
isReverifying.value && !reverifyError.value alongside the
currentVerificationStep/stepIndex check) so the step becomes non-active when a
reverifyError is set.
- Around line 165-175: The responsePromise created from $fetch (typed
KeytraceReverifyResponse) may reject while the subsequent runStep() delay calls
execute, causing unhandled rejection warnings; attach a rejection handler
immediately by calling Promise.allSettled([responsePromise]) (or otherwise
attach .catch) before invoking runStep(0..3), then await the original
responsePromise later as before so your existing try/catch still handles the
outcome; update the code around responsePromise and the runStep sequence in
AccountItem.vue accordingly.

In `@app/components/Compare/FacetSelector.vue`:
- Around line 108-113: The hover styles conflict between the static class
attribute and the conditional :class for facet.comingSoon, causing enabled hover
utilities (hover:(text-fg-muted border-border)) to potentially override the
muted hover (hover:(text-fg-subtle/50 border-border-subtle)); fix by moving
hover:(text-fg-muted border-border) out of the base class and into the
non-coming-soon branch of the :class binding (so only the enabled branch adds
enabled hover utilities), or alternatively replace with a disabled: modifier
pattern consistent with Button/Base.vue and Select/Base.vue so coming-soon chips
only receive the muted hover styles via facet.comingSoon conditional logic.

In `@app/components/LinkedAccounts.vue`:
- Around line 22-49: Replace hardcoded UI strings in the LinkedAccounts.vue
template with i18n lookups: use $t('profile.linked_accounts.title') for "Linked
Accounts"; replace the verified summary line that uses
verifiedCount/accounts.length with a translated key like
$t('profile.linked_accounts.verified_summary', { verified: verifiedCount, total:
accounts.length }); map each entry in statusLegend to use
$t('profile.linked_accounts.status.<key>') for the four legend labels and use
$t('profile.linked_accounts.legend_label') for the container aria-label; replace
"No linked accounts" with $t('profile.linked_accounts.empty'); ensure you update
the template expressions around verifiedCount, accounts, statusLegend, loading,
SkeletonBlock and AccountItem to call $t(...) consistently with the new
profile.* keys added to i18n/locales/*.json.

In `@app/components/ProfileHeader.vue`:
- Around line 53-67: Replace the hardcoded English strings in ProfileHeader.vue
with i18n lookups: change the alt fallback "Profile avatar" and the name
fallback "Unknown Profile" to use this.$t (or $t) with dedicated keys (e.g.
profile.avatarAlt and profile.unknown) so they respect the active locale; update
any template references that use profile.name || 'Unknown Profile' and
:alt="profile.name || 'Profile avatar'" to use the translated fallbacks, and add
corresponding keys under the profile.* namespace in the translation files to
match the project's i18n pattern.

In `@app/pages/profile/`[identity]/index.vue:
- Around line 101-105: The Keytrace UI (ProfileHeader and LinkedAccounts) is
being rendered for all identity routes because useKeytraceProfile(identity) is
invoked unconditionally and the mock API returns synthesized profiles for
unknown domains; update the rendering to gate the Keytrace-related components by
detecting domain-like identities (e.g. a simple regex check on identity) or by
checking a real Keytrace signal before rendering: call
useKeytraceProfile(identity) only when identity matches a domain pattern (or add
a boolean like isDomainFromIdentity) and wrap ProfileHeader and LinkedAccounts
with that condition (references: useKeytraceProfile, ProfileHeader,
LinkedAccounts, identity) so non-domain handles do not show fabricated linked
accounts.

In `@i18n/locales/de-AT.json`:
- Around line 27-28: The strings for keys "likes_error" and "likes_empty"
currently say "Beliebte Pakete" (popular packages) but should refer to the
user's liked packages; update the translations for likes_error and likes_empty
so they use a German phrase meaning "liked packages" (e.g., use a localized term
such as "Gemerkte Pakete" or "Gelikte Pakete") to correctly reflect the
profile's liked-packages section.

In `@i18n/locales/te-IN.json`:
- Around line 126-128: The three Telugu locale entries
"public_interests_description", "likes_error", and "likes_empty" are still in
English; update their values to proper Telugu translations (replace the English
strings with Telugu equivalents) or remove these keys from te-IN.json until
translations are available so Telugu users don't see English UI; locate these
keys in the i18n/locales/te-IN.json file and either provide accurate Telugu text
for public_interests_description, likes_error, and likes_empty or revert/delete
them to keep the locale as a placeholder.

In `@server/api/keytrace/reverify.post.ts`:
- Around line 21-26: The current reverify handler always returns a
KeytraceReverifyResponse with status: 'unverified', which will incorrectly
downgrade verified accounts; update the handler that builds the response (the
code creating the response object in reverify.post) to preserve the account's
current status instead of hardcoding 'unverified' — e.g., read the incoming
request's currentStatus (or fetch the account's status from the same source the
UI uses) and set response.status = currentStatus, adjust failureReason to
null/empty when status is unchanged, and only set failureReason and 'unverified'
if a real verification attempt fails.

In `@test/e2e/interactions.spec.ts`:
- Around line 293-310: The test '"s" does not navigate when any modifier key is
pressed' is ambiguous because it focuses '#header-search' causing typed
modifiers like 'Shift+s' to insert text and potentially trigger navigation;
remove the focus and the subsequent expect(searchInput).toBeFocused() lines from
this test so it mirrors the '"c"' modifier test (no editable focused) and
reliably asserts the URL stays on /settings; if you need coverage for shortcuts
being suppressed while an editable is focused, add a separate test named e.g.
'"s" is suppressed while editable is focused' that focuses '#header-search' and
verifies an unmodified 's' does not trigger navigation.

---

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 117-118: Replace the hard-coded path in the "👑 Fix Git ownership"
step by using the GitHub Actions runtime variable: update the git config
--global --add safe.directory command to use $GITHUB_WORKSPACE instead of the
literal "/__w/npmx.dev/npmx.dev" so the safe.directory is set dynamically for
the checked-out repo.

In `@app/components/LinkedAccounts.vue`:
- Around line 4-9: The statusLegend array uses raw Tailwind color utilities
(statusLegend, className) which bypass the app's semantic design tokens; replace
these hardcoded palette classes with semantic token-based classes (e.g., create
status-specific utility classes like .status-verified, .status-unverified,
.status-stale, .status-failed that map to tokens such as bg-bg-subtle /
text-fg-muted / border-border or token variants for each status) and update
statusLegend.className to reference those semantic classes so the badges respect
theme/accent settings and verify contrast in both light and dark themes.

In `@app/composables/useKeytraceProfile.ts`:
- Line 1: The explicit import of KeytraceAccount and KeytraceResponse at the top
of useKeytraceProfile.ts duplicates the repo's Nuxt auto-imports for
shared/types in composables; remove the line "import type { KeytraceAccount,
KeytraceResponse } from '#shared/types/keytrace'" and rely on the project-wide
auto-imported types (references to KeytraceAccount and KeytraceResponse inside
the useKeytraceProfile composable should continue to work without the explicit
import).

In `@CONTRIBUTING.md`:
- Line 351: Update the CONTRIBUTING.md note to mention that Nuxt's typedPages
option is experimental and that the type-safety guarantees for using
object-syntax named routes depend on enabling typedPages in nuxt.config.ts;
specifically, add a short parenthetical after the sentence that recommends
"object syntax with named routes" referencing the experimental nature of the
typedPages option and instructing contributors to enable typedPages in
nuxt.config.ts to get the typed route benefits.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b8efc060-b9db-4969-8d02-e8ed9e9c58f0

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3bfeb and d142652.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (54)
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
  • app/components/AccountItem.vue
  • app/components/Compare/FacetSelector.vue
  • app/components/LinkedAccounts.vue
  • app/components/ProfileHeader.vue
  • app/composables/useConnector.ts
  • app/composables/useKeytraceProfile.ts
  • app/pages/profile/[identity]/index.vue
  • docs/package.json
  • i18n/locales/ar-EG.json
  • i18n/locales/ar.json
  • i18n/locales/az-AZ.json
  • i18n/locales/bg-BG.json
  • i18n/locales/bn-IN.json
  • i18n/locales/cs-CZ.json
  • i18n/locales/de-AT.json
  • i18n/locales/de-DE.json
  • i18n/locales/de.json
  • i18n/locales/en-GB.json
  • i18n/locales/en.json
  • i18n/locales/es-419.json
  • i18n/locales/es.json
  • i18n/locales/fr-FR.json
  • i18n/locales/hi-IN.json
  • i18n/locales/hu-HU.json
  • i18n/locales/id-ID.json
  • i18n/locales/it-IT.json
  • i18n/locales/ja-JP.json
  • i18n/locales/kn-IN.json
  • i18n/locales/mr-IN.json
  • i18n/locales/nb-NO.json
  • i18n/locales/ne-NP.json
  • i18n/locales/nl.json
  • i18n/locales/pl-PL.json
  • i18n/locales/pt-BR.json
  • i18n/locales/ru-RU.json
  • i18n/locales/sr-Latn-RS.json
  • i18n/locales/ta-IN.json
  • i18n/locales/te-IN.json
  • i18n/locales/tr-TR.json
  • i18n/locales/uk-UA.json
  • i18n/locales/vi-VN.json
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json
  • i18n/schema.json
  • knip.ts
  • lighthouse-setup.cjs
  • package.json
  • pnpm-workspace.yaml
  • server/api/keytrace/[domain].ts
  • server/api/keytrace/reverify.post.ts
  • shared/types/keytrace.ts
  • test/e2e/interactions.spec.ts
💤 Files with no reviewable changes (1)
  • knip.ts

Comment thread app/components/AccountItem.vue
Comment thread app/components/AccountItem.vue Outdated
Comment thread app/components/Compare/FacetSelector.vue Outdated
Comment thread app/components/LinkedAccounts.vue
Comment thread app/components/ProfileHeader.vue Outdated
Comment thread app/pages/profile/[identity]/index.vue Outdated
Comment thread i18n/locales/de-AT.json Outdated
Comment thread i18n/locales/te-IN.json Outdated
Comment thread server/api/keytrace/reverify.post.ts Outdated
Comment thread test/e2e/interactions.spec.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 57.05128% with 67 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/AccountItem.vue 49.12% 47 Missing and 11 partials ⚠️
app/composables/useKeytraceProfile.ts 64.70% 5 Missing and 1 partial ⚠️
app/components/LinkedAccounts.vue 85.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@BittuBarnwal7479 BittuBarnwal7479 changed the title feat(profile): add Keytrace-style identity visualizer (POC) feat(ui): add keytrace-style identity visualizer (poc) Apr 23, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
i18n/locales/en.json (1)

305-349: ⚠️ Potential issue | 🟡 Minor

Keep common.error while it is still referenced.

app/storybook/mocks/handlers/lunaria-status.ts still references common.error; removing it from the source locale will surface a missing translation key there unless the consumer is updated.

Proposed fix
   "common": {
+    "error": "Error",
     "loading": "Loading...",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@i18n/locales/en.json` around lines 305 - 349, Restore the removed translation
key by re-adding "error" under the "common" object in the locale (so
common.error exists) with an appropriate string (e.g., "Error") because
app/storybook/mocks/handlers/lunaria-status.ts still references common.error;
alternatively update that handler to use an existing key if you intend to remove
common.error, but do one of these so the missing translation key is resolved.
i18n/locales/de.json (1)

300-344: ⚠️ Potential issue | 🟠 Major

Restore common.error for existing translation consumers.

app/storybook/mocks/handlers/lunaria-status.ts:30-50 still requests common.error, so deleting the shared key risks missing translations in that mock path.

Proposed fix
   "common": {
     "loading": "Lädt...",
     "loading_more": "Lädt mehr...",
     "loading_packages": "Pakete werden geladen...",
     "end_of_results": "Keine weiteren Ergebnisse",
     "try_again": "Erneut versuchen",
+    "error": "Fehler",
     "close": "Schließen",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@i18n/locales/de.json` around lines 300 - 344, Restore the removed
"common.error" key in the German locale so existing consumers (e.g., the
lunaria-status mock that references common.error) continue to find a
translation; add an appropriate German string like "Fehler" or a full sentence
under the "common" object with the key "error" to mirror other locales, ensuring
the key name is exactly "common.error" so code paths referencing common.error
(such as the handler in app/storybook/mocks/handlers/lunaria-status.ts) work
without changes.
i18n/locales/ja-JP.json (1)

171-210: ⚠️ Potential issue | 🟠 Major

Restore common.error for existing translation consumers.

app/storybook/mocks/handlers/lunaria-status.ts:30-50 still includes common.error; removing it from this locale can make the mock translation payload fail or render a missing key.

Proposed fix
   "common": {
     "loading": "読み込み中...",
     "loading_more": "さらに読み込み中...",
     "loading_packages": "パッケージを読み込み中...",
     "end_of_results": "結果の最後です",
     "try_again": "もう一度お試しください",
+    "error": "エラー",
     "close": "閉じる",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@i18n/locales/ja-JP.json` around lines 171 - 210, The ja-JP locale removed the
common.error key which breaks consumers expecting it (storybook mock in
app/storybook/mocks/handlers/lunaria-status.ts references common.error); restore
the common.error string in the "common" object of i18n/locales/ja-JP.json with
an appropriate Japanese translation (e.g., "エラーが発生しました") so the mock translation
payload and any runtime lookups find the key.
🧹 Nitpick comments (2)
test/nuxt/a11y.spec.ts (1)

910-968: Consider expanding state coverage for the new a11y suites.

Current tests only exercise the "happy path" (populated profile, single verified GitHub account). Since ProfileHeader has distinct avatar/initials fallback branches and LinkedAccounts/AccountItem render differently per status (verified / unverified / stale / failed) and loading, adding a few more cases would catch real accessibility regressions (e.g. missing alt on the fallback avatar, colour-contrast issues on non-verified status badges, skeleton/loading ARIA).

Suggested additional cases:

  • ProfileHeader: loading: true, and a profile with no avatar (initials fallback).
  • LinkedAccounts: empty accounts: [], loading: true, and a mix containing unverified/stale/failed statuses.
  • AccountItem: one test per non-verified status.

Not blocking for the POC, but cheap to add here so the audit actually covers the new visual states.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@test/nuxt/a11y.spec.ts` around lines 910 - 968, Add a few more a11y test
cases to exercise non-happy-path states: for ProfileHeader add tests for
loading: true and for a profile without an avatar (initials fallback) using
mountSuspended(ProfileHeader) and runAxe; for LinkedAccounts add tests for
accounts: [] (empty list), loading: true, and a mixed list containing statuses
'unverified', 'stale', and 'failed'; for AccountItem add separate tests
rendering AccountItem for each non-verified status
('unverified','stale','failed') and run runAxe against each mounted component to
assert no violations. Ensure each test uses the same mountSuspended/props
pattern so the axe audit covers fallback avatar, status badges, and loading
skeleton ARIA states.
i18n/locales/de-AT.json (1)

24-43: Avoid duplicating base German strings in the Austrian variant.

These profile entries are identical to de.json, so de-AT.json can inherit them from the base locale and only override Austria-specific wording.

Proposed cleanup
-  "search": {
+  "search": {
     "instant_search": "Schnellsuche",
     "instant_search_on": "Schnellsuche aktiviert",
     "instant_search_off": "Schnellsuche deaktiviert",
     "instant_search_turn_on": "Schnellsuche aktivieren",
     "instant_search_turn_off": "Schnellsuche deaktivieren",
     "instant_search_advisory": "Die Schnellsuche sendet bei jedem Tastendruck eine Anfrage."
-  },
-  "profile": {
-    "public_interests_description": "Öffentliche Paketinteressen und Aktivitätssignale.",
-    "likes_error": "Gelikte Pakete konnten nicht geladen werden.",
-    "likes_empty": "Noch keine gelikten Pakete.",
-    "avatar_alt": "Profilavatar",
-    "unknown_profile": "Unbekanntes Profil",
-    "linked_accounts": {
-      "status": {
-        "verified": "Verifiziert",
-        "unverified": "Nicht verifiziert",
-        "stale": "Veraltet",
-        "failed": "Fehlgeschlagen"
-      },
-      "title": "Verknüpfte Konten",
-      "verified_summary": "Verifizierte Konten",
-      "legend_aria_label": "Legende zum Verifizierungsstatus von Konten",
-      "empty": "Keine verknüpften Konten"
-    }
   }

Based on learnings, “when using country locale variants (e.g., es-419, es-ES), place only translations that differ from the base language in variant JSON files.”

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@i18n/locales/de-AT.json` around lines 24 - 43, The de-AT locale duplicates
the entire "profile" block from the base German locale; remove the redundant
keys under "profile" in de-AT.json and leave only Austria-specific overrides (if
none, remove the "profile" object entirely) so the app falls back to de.json for
shared strings; target the "profile" object and its nested keys like
"public_interests_description", "likes_error", "likes_empty", "avatar_alt",
"unknown_profile", and the "linked_accounts" block when pruning duplicates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@i18n/locales/de-DE.json`:
- Around line 16-17: The German locale entry "verified_summary" currently is a
static label and must include the interpolation placeholders used by
app/components/LinkedAccounts.vue; update the "verified_summary" value in
i18n/locales/de-DE.json to include the {verified} and {total} placeholders (e.g.
a German phrase using {verified} and {total}) so the component's passed values
are rendered in the UI.

In `@i18n/locales/en.json`:
- Around line 378-379: The "verified_summary" translation currently returns a
static label; update the en.json "verified_summary" value to include
interpolation placeholders for the counts (e.g., {verified} and {total}) so the
string uses the { verified, total } values passed from
app/components/LinkedAccounts.vue; keep the placeholder names matching what
LinkedAccounts.vue supplies and preserve pluralization/formatting conventions
used by your i18n setup.

In `@i18n/schema.json`:
- Around line 1114-1130: The AccountItem.vue component is still using hardcoded
English labels for account status; update it to read the new i18n keys under
profile.linked_accounts.status (e.g. profile.linked_accounts.status.verified,
.unverified, .stale, .failed) instead of literal strings. Locate the status
display logic in AccountItem.vue (the template or computed that currently
returns "Verified", "Unverified", "Stale", "Failed") and replace those literals
with calls to the translation helper (e.g. this.$t or $t in the template) so the
UI uses profile.linked_accounts.status.* keys for all four statuses. Ensure any
mapping logic (status code -> label) uses the translation keys consistently and
falls back to a safe default if a key is missing.

---

Outside diff comments:
In `@i18n/locales/de.json`:
- Around line 300-344: Restore the removed "common.error" key in the German
locale so existing consumers (e.g., the lunaria-status mock that references
common.error) continue to find a translation; add an appropriate German string
like "Fehler" or a full sentence under the "common" object with the key "error"
to mirror other locales, ensuring the key name is exactly "common.error" so code
paths referencing common.error (such as the handler in
app/storybook/mocks/handlers/lunaria-status.ts) work without changes.

In `@i18n/locales/en.json`:
- Around line 305-349: Restore the removed translation key by re-adding "error"
under the "common" object in the locale (so common.error exists) with an
appropriate string (e.g., "Error") because
app/storybook/mocks/handlers/lunaria-status.ts still references common.error;
alternatively update that handler to use an existing key if you intend to remove
common.error, but do one of these so the missing translation key is resolved.

In `@i18n/locales/ja-JP.json`:
- Around line 171-210: The ja-JP locale removed the common.error key which
breaks consumers expecting it (storybook mock in
app/storybook/mocks/handlers/lunaria-status.ts references common.error); restore
the common.error string in the "common" object of i18n/locales/ja-JP.json with
an appropriate Japanese translation (e.g., "エラーが発生しました") so the mock translation
payload and any runtime lookups find the key.

---

Nitpick comments:
In `@i18n/locales/de-AT.json`:
- Around line 24-43: The de-AT locale duplicates the entire "profile" block from
the base German locale; remove the redundant keys under "profile" in de-AT.json
and leave only Austria-specific overrides (if none, remove the "profile" object
entirely) so the app falls back to de.json for shared strings; target the
"profile" object and its nested keys like "public_interests_description",
"likes_error", "likes_empty", "avatar_alt", "unknown_profile", and the
"linked_accounts" block when pruning duplicates.

In `@test/nuxt/a11y.spec.ts`:
- Around line 910-968: Add a few more a11y test cases to exercise non-happy-path
states: for ProfileHeader add tests for loading: true and for a profile without
an avatar (initials fallback) using mountSuspended(ProfileHeader) and runAxe;
for LinkedAccounts add tests for accounts: [] (empty list), loading: true, and a
mixed list containing statuses 'unverified', 'stale', and 'failed'; for
AccountItem add separate tests rendering AccountItem for each non-verified
status ('unverified','stale','failed') and run runAxe against each mounted
component to assert no violations. Ensure each test uses the same
mountSuspended/props pattern so the axe audit covers fallback avatar, status
badges, and loading skeleton ARIA states.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab559b41-ee63-4e79-a588-a0829e9bca5d

📥 Commits

Reviewing files that changed from the base of the PR and between d142652 and ad9e428.

📒 Files selected for processing (46)
  • app/components/AccountItem.vue
  • app/components/Compare/FacetSelector.vue
  • app/components/LinkedAccounts.vue
  • app/components/ProfileHeader.vue
  • app/composables/useKeytraceProfile.ts
  • app/pages/profile/[identity]/index.vue
  • i18n/locales/ar-EG.json
  • i18n/locales/ar.json
  • i18n/locales/az-AZ.json
  • i18n/locales/bg-BG.json
  • i18n/locales/bn-IN.json
  • i18n/locales/cs-CZ.json
  • i18n/locales/de-AT.json
  • i18n/locales/de-DE.json
  • i18n/locales/de.json
  • i18n/locales/en-GB.json
  • i18n/locales/en.json
  • i18n/locales/es-419.json
  • i18n/locales/es.json
  • i18n/locales/fr-FR.json
  • i18n/locales/hi-IN.json
  • i18n/locales/hu-HU.json
  • i18n/locales/id-ID.json
  • i18n/locales/it-IT.json
  • i18n/locales/ja-JP.json
  • i18n/locales/kn-IN.json
  • i18n/locales/mr-IN.json
  • i18n/locales/nb-NO.json
  • i18n/locales/ne-NP.json
  • i18n/locales/nl.json
  • i18n/locales/pl-PL.json
  • i18n/locales/pt-BR.json
  • i18n/locales/ru-RU.json
  • i18n/locales/sr-Latn-RS.json
  • i18n/locales/ta-IN.json
  • i18n/locales/te-IN.json
  • i18n/locales/tr-TR.json
  • i18n/locales/uk-UA.json
  • i18n/locales/vi-VN.json
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json
  • i18n/schema.json
  • server/api/keytrace/[domain].ts
  • server/api/keytrace/reverify.post.ts
  • shared/types/keytrace.ts
  • test/nuxt/a11y.spec.ts
✅ Files skipped from review due to trivial changes (10)
  • i18n/locales/kn-IN.json
  • i18n/locales/it-IT.json
  • i18n/locales/te-IN.json
  • i18n/locales/en-GB.json
  • i18n/locales/ta-IN.json
  • i18n/locales/es-419.json
  • i18n/locales/id-ID.json
  • app/components/LinkedAccounts.vue
  • shared/types/keytrace.ts
  • app/pages/profile/[identity]/index.vue
🚧 Files skipped from review as they are similar to previous changes (23)
  • i18n/locales/bn-IN.json
  • i18n/locales/ne-NP.json
  • i18n/locales/es.json
  • i18n/locales/nl.json
  • i18n/locales/ru-RU.json
  • i18n/locales/pt-BR.json
  • i18n/locales/mr-IN.json
  • i18n/locales/fr-FR.json
  • i18n/locales/hi-IN.json
  • i18n/locales/zh-CN.json
  • i18n/locales/pl-PL.json
  • i18n/locales/tr-TR.json
  • i18n/locales/ar-EG.json
  • server/api/keytrace/reverify.post.ts
  • app/components/Compare/FacetSelector.vue
  • server/api/keytrace/[domain].ts
  • app/components/ProfileHeader.vue
  • i18n/locales/az-AZ.json
  • i18n/locales/bg-BG.json
  • app/components/AccountItem.vue
  • i18n/locales/hu-HU.json
  • i18n/locales/cs-CZ.json
  • i18n/locales/uk-UA.json

Comment thread i18n/locales/de-DE.json
Comment on lines +16 to +17
"title": "Verknüpfte Konten",
"verified_summary": "Verifizierte Konten",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Render the verified-account counts in the summary.

Line 17 ignores the { verified, total } values passed by app/components/LinkedAccounts.vue, so the German UI will only show a static label instead of the verification summary.

Proposed fix
-      "verified_summary": "Verifizierte Konten",
+      "verified_summary": "{verified}/{total} verifiziert",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@i18n/locales/de-DE.json` around lines 16 - 17, The German locale entry
"verified_summary" currently is a static label and must include the
interpolation placeholders used by app/components/LinkedAccounts.vue; update the
"verified_summary" value in i18n/locales/de-DE.json to include the {verified}
and {total} placeholders (e.g. a German phrase using {verified} and {total}) so
the component's passed values are rendered in the UI.

Comment thread i18n/locales/en.json Outdated
Comment thread i18n/schema.json
Your Name and others added 2 commits April 24, 2026 03:44
@github-actions
Copy link
Copy Markdown

e18e dependency analysis

No dependency warnings found.

@patak-cat
Copy link
Copy Markdown
Contributor

For some claim types (for example DNS identities like zeu.dev), Keytrace does not return [avatarUrl] so the avatar was empty and appeared to disappear.

This is fine. The one that isn't showing is the one in the Profile Header above the Linked Accounts. The image for zeu.dev links to this svg from dicebear and it is broken when it is used in the site. I don't know what is the idea for this section:
image

I think you can remove it.

@BittuBarnwal7479
Copy link
Copy Markdown
Contributor Author

For some claim types (for example DNS identities like zeu.dev), Keytrace does not return [avatarUrl] so the avatar was empty and appeared to disappear.

This is fine. The one that isn't showing is the one in the Profile Header above the Linked Accounts. The image for zeu.dev links to this svg from dicebear and it is broken when it is used in the site. I don't know what is the idea for this section: image

I think you can remove it.

Hi @patak-cat , thanks for the review.
I’ve now addressed:

  • Removed the Identity profile header
  • Kept real Keytrace avatars when present and only use fallback when missing.
  • Fixed avatar rendering for identities where Keytrace does not return avatarUrl (for example DNS claims) by using deterministic fallback avatars.
  • Routed both profile and account avatars through our internal image proxy, which resolves the CSP blocking issue from direct Dicebear URLs.

@serhalp serhalp added the needs review This PR is waiting for a review from a maintainer label Apr 27, 2026
@Tobbe
Copy link
Copy Markdown
Contributor

Tobbe commented May 25, 2026

Thanks for working on this @BittuBarnwal7479

I just tried it at https://npmx-rcact1v5f-npmx.vercel.app/profile/tobbe.dev and this is what I see
image

Keytrace itself shows this

image
  1. Would it be possible to make npmx also say "bsky" instead of just "other"?
  2. I think it'd be nice with some explanation of what the different badges mean. I initially had "stale" on both my linked account, and didn't know what that meant or what to do about it. I eventually just tried refreshing them at keytrace, and that changed them to the current "verified" state.

@BittuBarnwal7479
Copy link
Copy Markdown
Contributor Author

Thanks for working on this @BittuBarnwal7479

I just tried it at https://npmx-rcact1v5f-npmx.vercel.app/profile/tobbe.dev and this is what I see image

Keytrace itself shows this

image 1. Would it be possible to make npmx also say "bsky" instead of just "other"? 2. I think it'd be nice with some explanation of what the different badges mean. I initially had "stale" on both my linked account, and didn't know what that meant or what to do about it. I eventually just tried refreshing them at keytrace, and that changed them to the current "verified" state.

Thanks for review!
I'll update the labels to properly show bsky instead of other, and i agree that adding clearer explanations for the badge states would improve the UX.

I also noticed the merge conflicts and will resolve them.

I’m currently in the middle of my final B.Tech end exams, so updates might be a bit slower for the next few days, but I’ll continue working on the requested changes as soon as possible.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jun 4, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​keytrace/​claims@​1.4.07610010094100

View full report

@BittuBarnwal7479
Copy link
Copy Markdown
Contributor Author

@Tobbe pls review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review This PR is waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt keytrace

4 participants